-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Ability to cache/store music offline #569
Comments
I was thinking the same thing. Why waste bandwidth+CPU+memory on downloading something we already downloaded, and are likely to download again (and again, and again...). Songs could simply be stored in a rolling cache. |
We'd love to support that, but it's obviously a legal minefield. Some plugins like Spotify do their own internal caching though. |
Could it be possible to add something similar to the "Collection" interface that's shared between C++ and JS, so that resolvers could use that to cache the songs' data ? |
Right. Everything is cached somewhere, it's just not something TH is controlling or accessing. It might be, as muesli said, a "legal minefield", but not for all sources. |
Might be worth researching which services would allow such action? I'll start, pretty sure youtube is out - in fact even the current youtube functionality of TH might be in violation: https://www.youtube.com/t/terms 4. General Use of the Service—Permissions and Restrictions
6. Your Content and Conduct
|
Jamendo content may be cached: https://www.jamendo.com/legal/terms-of-use CLAUSE 1. DEFINITIONS
CLAUSE 3. USE OF SERVICES3.2 - Technical Information
|
Last.fm audio may not be cached: http://www.last.fm/legal/terms 3. Intellectual Property Ownership; Licence
|
Bandcamp audio may be cached: https://bandcamp.com/terms_of_use Intellectual Property Rights – Artists.
|
Soundcloud audio may be cached given certain circumstances: https://soundcloud.com/terms-of-use Your use of the Platform
|
That's most of the free streaming services, (couldnt access Official.fm), ill let someone else do the subscription and network/cloud ones. The only way around such things may be non-profit / fair use, but someone else can also look into that, lookin forward to it though, IMHO this could be the music player to end all music players. |
Nice work @MWrathDev ! |
dam i just istalled this app, too bad you cant use offline that the reason i wanted it , i have spotify premium , soundcloud and bandcamp songs as well but its anoying to cant play everything offline in the same app... |
Useful when having no internet access, poor speed or bandwidth.
The text was updated successfully, but these errors were encountered: