Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomahawk 0.84 Mac OS X Sierra does not show any album art (FLAC files on NAS) #591

Open
franktopel opened this issue Jan 9, 2017 · 17 comments

Comments

@franktopel
Copy link

franktopel commented Jan 9, 2017

I store my music in flac format on a NAS (Zyxel NSA325 v2) and have setup an read-only user to access files from my Mac (so it doesn't create those typical Mac files in all the folders).

I do not see a single album artwork, see the attached picture. What am I to do?

image

This is how a typical folder looks:

image

@franktopel franktopel changed the title Tomahawk 0.8 Mac OS X Sierra does not show any album art (FLAC files on NAS) Tomahawk 0.84 Mac OS X Sierra does not show any album art (FLAC files on NAS) Jan 9, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

Facing the same problem here! All artwork is empty and I can't even connect to last.fm. Fortunately the song can be played. I think that is a connectivity problem causing this bug...

@McCauliflower
Copy link

McCauliflower commented Feb 7, 2017

I'm experiencing this issue as well.

@muesli
Copy link
Member

muesli commented Feb 7, 2017

Not being able to connect to Last.fm is the reason you're not seeing any album art. We don't read the art from local files, we fetch it from there. I'm not sure how MacOS Sierra would cause this, but I didn't experience it on previous MacOS versions. I don't currently use MacOS any longer, so someone else will have to look into this.

@felixroos
Copy link

i have the same problem with all music files on sierra. Tomahawk does not show any images at all.

@franktopel
Copy link
Author

franktopel commented Feb 7, 2017

Why would you not use local art files? At least there should be an option to allow for local art to be used. I have all cover art directly within the album folders in high quality. Do I need to have and configure a Last.fm account to see album art in Tomahawk then?

@muesli
Copy link
Member

muesli commented Feb 7, 2017

No, their API endpoint for images doesn't require auth and so you don't need an account there or configure the Last.fm resolver.

Due to the nature of online services and resolvers we can't purely rely on local cover art (e.g. it wouldn't help if you play a song from SoundCloud), so we implemented this as a source first. Since it covers 99.9% of all "cover art needs", nobody ever bothered working on reading local cover art. If anybody's interested in taking this job, I'll happily guide them and merge it.

@franktopel
Copy link
Author

Okay, so what are you suggesting to get this "no cover art" issue fixed? I'm a developer, but purely web frontend.

@muesli
Copy link
Member

muesli commented Feb 7, 2017

I'm afraid I don't have the slightest idea what would/could be causing this on MacOS Sierra only. I'd try the latest nightly from here first: http://download.tomahawk-player.org/nightly/mac/Tomahawk-latest.dmg

@mvrueden
Copy link

mvrueden commented Feb 24, 2017

I had the same issue as described here. The suggestion from @muesli worked for me: I can confirm that with the latest version of Tomahawk I now see album art. Thank you.

@jfml
Copy link

jfml commented Mar 8, 2017

Nightly displays cover art of local files as well for me (0.84 doesn't) but the song notifications are not working. Should I open this as a new issue or not for nightly?

@hutber
Copy link

hutber commented Mar 19, 2017

Viewing local would still be cool I think. I have quite a few albums that are not on last-fm... Maybe if last-fm doesn't have it, check local?

@jfml
Copy link

jfml commented Mar 19, 2017

@jamiehutber I think so, too. I also don't know if these get cached because for me they need to get reloaded everytime I start the app (it is pretty fast but you still have to wait for images to load when you're scrolling through albums).

@hutber
Copy link

hutber commented Mar 19, 2017

Ye, I've also had problems with being unable to play songs that last-fm couldn't find.

Basically this is the closest music player to winamp that I have found. I am super happy to keep making suggestions to get this to be the best on linux.

@muesli
Copy link
Member

muesli commented Mar 19, 2017

Covers will get cached, but only loaded once shown for the first time.

@duraki
Copy link

duraki commented Mar 20, 2017

Just wanted to confirm here that player ain't showing album art event tho I have it on my local filesystem. This happens on MacOS Sierra, Tomahawk version 0.8.4. For some reason, the album art is not being fetched from Last.fm too.

@JDLH
Copy link

JDLH commented Apr 18, 2017

I am seeing the same problem: the cover art I so carefully added to my LAN-hosted FLAC files is not being displayed. This is a big drawback for me. I have lots of obscure modern classical music, so I would expect LAST.fm to be missing some of it. I would upvote the enhancement of using local cover art if present.

I am using Tomahawk player 0.8.4 on Mac OS X 10.11.

@richbos
Copy link

richbos commented Sep 2, 2017

+1 on this. My collection has local cover art embedded in the file(s) and adding it is the first thing I do after importing a CD. I wouldn't want to have to connect to an(other) external/online service to repopulate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants