Full Keystore, Truststore and ClientAuth support #199
Conversation
|
This looks good, but please could you add some tests and documentation? Thanks, |
|
Strange coincidence but I also got this PR, for exactly the same thing: The other PR has some decent looking tests, but doesn't add the relevant CLI params whereas this PR does, but lacks tests. Perhaps you and @ke4roh could get your heads together and combine the two? |
|
Thanks for the review! I made another commit to add UT and IT to cover the new feature. |
This commit added UT and IT to cover the SSL support featre. Namely: * Introduced RestAssured as the client to simplify the testing code * Create a set of PKI and CA for testing different combinations of keystore and turststore in local environment * Added UT to cover HttpsSettings, WireMockConfiguration and CommandLineOptions class * Added IT to cover the case where WireMock server quires client auth
t1ngj13
force-pushed
the
truststore_support
branch
from
79d2b09
to
13ed9bf
Compare
|
Hi Tom - Just want to check if there is any further comments on the updated test case? |
|
I'm having a bit of trouble making sense of this PR because you seem to have reformatted all the files you've opened. Also, I'd prefer not to introduce a new test framework at this stage. Could you re-issue with formatting fixed and using HTTPClient for the testing? |
|
OK, I will update the issues during this weekend. Thanks! |
|
Jay, You might like to just grab the tests from here: Jim On Fri, Dec 12, 2014 at 7:52 PM, Jay Zhu notifications@github.com wrote:
|
|
Closing as #201 adds this feature. |
As of 1.52, wiremock only supports specifying https port with a keystore, and keystore password is always assumed to be "password". This is quite limited. In many scenario, we want to specify more advanced parameters, for example:
This pull request essentially exposes more native Jetty connector parameters through the
HttpsSettingsclass, from which we will be able to specify the following parameters:To maintain backward compatibility, default keystore password is still kept as 'password' if it is not specified.