-
Notifications
You must be signed in to change notification settings - Fork 164
Several input formats supported by 7zip were added #11
Conversation
Anyone else could confirm some of those new formats ? |
Here is the cite from the official 7z source code (file CPP/7zip/Guid.txt):
Actually, these formats aren't new. For example, SquashFS support that I've tested was added to 7-Zip 9.18 beta at 2010-11-02 according to the official release notes |
… they had to be very old (RAR5 was added to 7z 15.12 (2015-11-19).
…"SevenZipTest" project. Looking at them they need to be rewritten.
* Output now in /Stage/... * Switches between x32/x64 7z.dll Also test now works.
…wo problems (extracting .gz and .bz2 archives), set as warnings for now.
RAR5 support and unit tests
…veral old problems it seems.
…s in a row" is a good fit for unit tests.
…t other tests, so I'm left with just one...
…word parameter ("").
…Had to embedd the .sfx modules, and I added some logic around 32/64-bit versions of these modules, where applicable.
Maybe solved the creation of SFX archives
If this is something you'd still want added, create a PR at https://github.com/squid-box/SevenZipSharp and I'll try to add it - like tomap I'd prefer more testing, but there are already several formats I've not been able to test properly, so why not add some more? :) |
Source.Position = value; | ||
} | ||
get => Source.Position - Offset; | ||
set => Source.Position = value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be value + Offset
or getter is wrong
PR name is completely wrong. This PR mostly about unit testing. |
... and files formatting. Very important things were made by this PR, like:
was replaced by:
This is very relevant to PR purpose! |
I recommend to reject the PR. |
@mbobka: somehow this pull request has the same activity as the one arttarasov opened on my fork. As is clearly seen his commit is the one related to the PR title, the rest is the entirety of my fork history. Tomap has ceased development of this fork anyway, so I wouldn't worry to much. |
Unfortunately, it was tested only with SquashFS file format.
The list of supported formats was found here