Skip to content
This repository has been archived by the owner on Sep 20, 2018. It is now read-only.

Several input formats supported by 7zip were added #11

Closed
wants to merge 72 commits into from

Conversation

arttarasov
Copy link

Unfortunately, it was tested only with SquashFS file format.
The list of supported formats was found here

@tomap
Copy link
Owner

tomap commented Oct 26, 2017

Anyone else could confirm some of those new formats ?

@arttarasov
Copy link
Author

Here is the cite from the official 7z source code (file CPP/7zip/Guid.txt):

Handler GUIDs:

{23170F69-40C1-278A-1000-000110xx0000}

  01 Zip
  02 BZip2
  03 Rar
  04 Arj
  05 Z
  06 Lzh
  07 7z
  08 Cab
  09 Nsis
  0A lzma
  0B lzma86
  0C xz
  0D ppmd

  C7 Ext
  C8 VMDK
  C9 VDI
  CA Qcow
  CB GPT
  CC Rar5
  CD IHex
  CE Hxs
  CF TE
  D0 UEFIc
  D1 UEFIs
  D2 SquashFS
  D3 CramFS
  D4 APM
  D5 Mslz
  D6 Flv
  D7 Swf
  D8 Swfc
  D9 Ntfs
  DA Fat
  DB Mbr
  DC Vhd
  DD Pe
  DE Elf
  DF Mach-O
  E0 Udf
  E1 Xar
  E2 Mub
  E3 Hfs
  E4 Dmg
  E5 Compound
  E6 Wim
  E7 Iso
  E8 
  E9 Chm
  EA Split
  EB Rpm
  EC Deb
  ED Cpio
  EE Tar
  EF GZip

Actually, these formats aren't new. For example, SquashFS support that I've tested was added to 7-Zip 9.18 beta at 2010-11-02 according to the official release notes

… they had to be very old (RAR5 was added to 7z 15.12 (2015-11-19).
…"SevenZipTest" project. Looking at them they need to be rewritten.
* Output now in /Stage/...
* Switches between x32/x64 7z.dll

Also test now works.
…wo problems (extracting .gz and .bz2 archives), set as warnings for now.
RAR5 support and unit tests
@squid-box
Copy link

If this is something you'd still want added, create a PR at https://github.com/squid-box/SevenZipSharp and I'll try to add it - like tomap I'd prefer more testing, but there are already several formats I've not been able to test properly, so why not add some more? :)

Source.Position = value;
}
get => Source.Position - Offset;
set => Source.Position = value;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be value + Offset or getter is wrong

@mbobka
Copy link

mbobka commented Sep 20, 2018

PR name is completely wrong. This PR mostly about unit testing.

@mbobka
Copy link

mbobka commented Sep 20, 2018

... and files formatting. Very important things were made by this PR, like:

       public int ChunkSize
       {
            get
            {
                return (int) _buffer.Length;
            }
        }

was replaced by:

        public int ChunkSize => (int) _buffer.Length;

This is very relevant to PR purpose!

@mbobka
Copy link

mbobka commented Sep 20, 2018

I recommend to reject the PR.

@squid-box
Copy link

@mbobka: somehow this pull request has the same activity as the one arttarasov opened on my fork. As is clearly seen his commit is the one related to the PR title, the rest is the entirety of my fork history.

Tomap has ceased development of this fork anyway, so I wouldn't worry to much.

@tomap tomap closed this Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants