Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 307 as a valid redirection code #189

Merged
merged 1 commit into from Oct 24, 2016
Merged

Conversation

lauracpierre
Copy link
Contributor

307 code is a valid redirection and is not accepted by Needle so far.

As explained by the w3.org website:

10.3.8 307 Temporary Redirect

The requested resource resides temporarily under a different URI. Since the redirection MAY be altered on occasion, the client SHOULD continue to use the Request-URI for future requests. This response is only cacheable if indicated by a Cache-Control or Expires header field.

The temporary URI SHOULD be given by the Location field in the response. Unless the request method was HEAD, the entity of the response SHOULD contain a short hypertext note with a hyperlink to the new URI(s) , since many pre-HTTP/1.1 user agents do not understand the 307 status. Therefore, the note SHOULD contain the information necessary for a user to repeat the original request on the new URI.

If the 307 status code is received in response to a request other than GET or HEAD, the user agent MUST NOT automatically redirect the request unless it can be confirmed by the user, since this might change the conditions under which the request was issued.

@lauracpierre
Copy link
Contributor Author

Hi @tomas any chance we can get this merged? We'd like to avoid linking our app to a fork ideally. Plus I think that could prevent more people from doing the same thing!

Thanks,
Pierre

@tomas
Copy link
Owner

tomas commented Oct 11, 2016

Yes, definitely. I'm out of town at the moment but will be back (fully)
online tomorrow.

On Mon, Oct 10, 2016 at 4:46 PM, Pierre Laurac notifications@github.com
wrote:

Hi @tomas https://github.com/tomas any chance we can get this merged?
We'd like to avoid linking our app to a fork ideally. Plus I think that
could prevent more people from doing the same thing!

Thanks,
Pierre


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#189 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAApTmSh1cMpaBmPt8B0_aiLjdtSVjlcks5qys5RgaJpZM4KQMyK
.

Fork Ltd.
forkhq.com

@lauracpierre
Copy link
Contributor Author

That's 👍🏻 thank you @tomas

@tomas tomas merged commit 5b9741b into tomas:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants