Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Modify multipart upload #8

Closed
wants to merge 1 commit into from

2 participants

@eastkiki

Modify build_multipart_body method

[[body + '--' + boundary + '--' ]] -> [[body + '--' + boundary + '--\r\n']]

@tomas
Owner

Hi,

Multipart works fine. What is the additional '\r\n' supposed to fix? This was recently changed, by the way:

8b91f9e

@tomas
Owner

Ok I'm closing down this issue. I've been testing multipart uploads using a number of different endpoints and it works fine. If you think the multipart body needs further revision please open up a new ticket.

@tomas tomas closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 30, 2012
  1. @eastkiki

    Modify multipart upload!

    eastkiki authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/needle.js
View
2  lib/needle.js
@@ -223,7 +223,7 @@ var Needle = {
this.generate_part(key, part, boundary, function(err, section){
if(err) return callback(err);
body += section;
- --count || callback(null, body + '--' + boundary + '--');
+ --count || callback(null, body + '--' + boundary + '--\r\n');
});
}
Something went wrong with that request. Please try again.