Update nugets (#30)

* Remove System.ValueTuple This should be picked up from the .NET Standard Library instead. * Update xUnit and Moq Due to improved support for parallel test runs in xUnit 2.3, we need to explicitly disable parallel test runs of the EF tests, because they're all re-using the same db instance. A better solution would be to refactor the test fixture and base class to create a new db-connection instance for each test, and use that. * Use xUnit asserts more idiomatically
tomasaschan · Oct 26, 2017 · 5694b2d · 5694b2d
1 parent 059a106
commit 5694b2d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/...dbmsEventStore.EntityFramework.Tests/ExtensibilityTests/NonDefaultImplementationsTests.cs b/...dbmsEventStore.EntityFramework.Tests/ExtensibilityTests/NonDefaultImplementationsTests.cs
@@ -2,7 +2,6 @@
 using System.ComponentModel.DataAnnotations;
 using System.ComponentModel.DataAnnotations.Schema;
 using System.Data.Entity;
-using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
 using RdbmsEventStore.EntityFramework.Tests.Infrastructure;
@@ -84,7 +83,7 @@ public async Task CanReadEventsFromStoreWithNonDefaultImplementations()
 
             var events = await store.Events(1);
 
-            Assert.Equal(1, events.Count());
+            Assert.Single(events);
         }
         public void Dispose()
         {

diff --git a/src/RdbmsEventStore.EntityFramework.Tests/Infrastructure/AssemblyInitializerFixture.cs b/src/RdbmsEventStore.EntityFramework.Tests/Infrastructure/AssemblyInitializerFixture.cs
@@ -10,6 +10,6 @@ public AssemblyInitializerFixture()
         }
     }
 
-    [CollectionDefinition(nameof(InMemoryDatabaseCollection))]
+    [CollectionDefinition(nameof(InMemoryDatabaseCollection), DisableParallelization = true)]
     public class InMemoryDatabaseCollection : ICollectionFixture<AssemblyInitializerFixture> { }
 }
diff --git a/src/RdbmsEventStore.EntityFramework.Tests/RdbmsEventStore.EntityFramework.Tests.csproj b/src/RdbmsEventStore.EntityFramework.Tests/RdbmsEventStore.EntityFramework.Tests.csproj
@@ -10,8 +10,8 @@
   <ItemGroup>
     <PackageReference Include="Effort.EF6" Version="1.3.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
-    <PackageReference Include="xunit" Version="2.2.0" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
+    <PackageReference Include="xunit" Version="2.3.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/RdbmsEventStore.Tests/RdbmsEventStore.Tests.csproj b/src/RdbmsEventStore.Tests/RdbmsEventStore.Tests.csproj
@@ -8,9 +8,9 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
-    <PackageReference Include="Moq" Version="4.7.137" />
-    <PackageReference Include="xunit" Version="2.2.0" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
+    <PackageReference Include="Moq" Version="4.7.142" />
+    <PackageReference Include="xunit" Version="2.3.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/RdbmsEventStore/RdbmsEventStore.csproj b/src/RdbmsEventStore/RdbmsEventStore.csproj
@@ -20,7 +20,6 @@
   <ItemGroup>
     <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
     <PackageReference Include="Nito.AsyncEx.Coordination" Version="1.0.2" />
-    <PackageReference Include="System.ValueTuple" Version="4.4.0" />
   </ItemGroup>
 
 </Project>