Add reset_ratelimit method. #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a reset_ratelimit method. This mostly useful during unit testing. Use case: I have a large amount of unit tests, a lot of them indirectly call my ratelimited function. I tried a lot of other things to get round this, but this seemed to work the best (in combination with faketime so things run instantly).
reset_ratelimit should reset num_calls to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method
reset_ratelimitwhich can be called at the beginning of a test and give the user some control over the ratelimit.During unit testing I needed to reset limits as I go.
While I can use freezegun and faketime to change date / duration, you still need a way to reset the limit so the test can run in a predictable manner.