Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use another town to test geocoding #104

Merged
merged 1 commit into from Aug 25, 2018
Merged

Use another town to test geocoding #104

merged 1 commit into from Aug 25, 2018

Conversation

tomasbedrich
Copy link
Owner

Fixes #101, please review @weinshec.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.348% when pulling b06d133 on fix-101 into 078aec9 on master.

weinshec
weinshec approved these changes Aug 25, 2018
View reviewed changes
Copy link
Collaborator

@weinshec weinshec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is always a US equivalent to european cities as it the case for Prague. However, this seems to work for now ;)

@tomasbedrich
Copy link
Owner Author

I found one without any alternative - Liberec in Czechia. But it doesn't have any English name, so I prefer to use another one to test the same result of geocoding English and Czech names. Hope Prague will be ok for some time.

@tomasbedrich tomasbedrich merged commit f75500e into master Aug 25, 2018
@tomasbedrich tomasbedrich deleted the fix-101 branch August 25, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinshec weinshec weinshec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomasbedrich @coveralls @weinshec