Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows runner configuration #150

Merged
merged 5 commits into from May 15, 2020
Merged

Add Windows runner configuration #150

merged 5 commits into from May 15, 2020

Conversation

FriedrichFroebel
Copy link
Collaborator

This adds Windows support for the Travis tests (see #134).

tomasbedrich
tomasbedrich requested changes May 15, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
@FriedrichFroebel
try to fix coverage error
d06e995 
Error shown on Travis:

> ImportError: cannot import name 'Reporter' from 'coverage.report'
@FriedrichFroebel
attempt to fix coverage for Linux as well
5abf87f
@FriedrichFroebel
Copy link
Collaborator Author

FriedrichFroebel commented May 15, 2020 •
edited

I fixed the coverage report with coveralls as well, but I am not sure about the following message:

PyYAML is not installed, skipping .coveralls.yml.

@tomasbedrich As I am not sure about it: Should we install pyyaml to eliminate this message and therefore allow handling the .coverall.yml file of the repository as well?

@tomasbedrich
Copy link
Owner

According to docs:

If coveralls-python is being run on TravisCI, it will automatically set the token for communication with coveralls.io. Otherwise, you should set the environment variable COVERALLS_REPO_TOKEN, ...

So I think we are safe to delete .coveralls.yml.

@FriedrichFroebel FriedrichFroebel linked an issue May 15, 2020 that may be closed by this pull request
Add Windows tests to CI #134
Closed
@FriedrichFroebel FriedrichFroebel merged commit c21ff39 into master May 15, 2020
@FriedrichFroebel FriedrichFroebel deleted the travis-windows branch May 15, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasbedrich tomasbedrich tomasbedrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Windows tests to CI
2 participants
@FriedrichFroebel @tomasbedrich