Fix getting user logs #233
Conversation
| @@ -494,8 +494,8 @@ def my_logs(self, log_type=None, limit=float("inf")): | |||
| break | |||
|
|
|||
| link = row.find(class_="ImageLink")["href"] | |||
| guid = parse_qs(urlparse(link).query)["guid"][0] | |||
| current_cache = self._try_getting_cache_from_guid(guid) | |||
| wp = link.split("/")[4] | |||
There was a problem hiding this comment.
Could we make this more explicit somehow or check that the removed prefix is correct? For now, this seems to be "magic", as we do not have automated tests for this at the moment as well.
There was a problem hiding this comment.
An explicit way of doing this might be using regular expressions, which are not recommended as per contribution guidelines. Also note that on line 470, a very similar extraction is done in a very similar way.
Would you consider this resolved if a comment is provided similarly to line 470? Or would you rather see explicit checking of the prefix or moving the "logic" to a separate function?
There was a problem hiding this comment.
In the easiest way, we can consider adding a comment with an example URL here to make this more clear.
There was a problem hiding this comment.
I added the comment in commit cdeeeca, please see if this is sufficient.
|
Has this been released yet or is it only in master at the moment? |
|
Now it is released as 4.4.1 |
Due to changes on the Geocaching website, iterating
my_logs()raises an exception due to a missing query argument "guid". This is caused by an upstream change at https://www.geocaching.com/my/logs.aspx, where the format of the URL that this library uses was changed to "https://www.geocaching.com/geocache/[WP]".This PR modifies the
my_logs()method to use WP to find the geocache details instead of guid, which fixes the problem.