Mystery original coords #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original_location is set if the user has updated the cache coordinates. The new coordinates (entered by the user) will still show up as location and the old cooredinates will be stored in original_location
|
Great! The last thing remains - to fix this subtest: https://github.com/forslund/pycaching/blob/9bfa7b0be92db75120d9c5a622b7d7f5fedcbd2b/test/test_cache.py#L79 |
|
Thank you. Can you please add a separate issue for your idea of more locations for one cache? Including some draft – what solution would be nice according to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple solution for #37. A new property
orginal_locationis added to the Cache-object.As I implemented this I started thinking that this might not be the best way, maybe we should intruduce a dictionary named additional_locations which contains any additional coordinates. Since many caches have extra locations such as coordinates for parking or for the different steps in a multi-cache.
Any thoughts?