Catch exception if waypoint location is invalid #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2016 23:24
When parsing waypoints from the HTML table it is not guaranteed that the location is in proper format, e.g. hidden stages have '???' in the location field (see e.g. GC3WTTZ). This caused an unhandled exception in `Waypoint.from_html()`. Fixing this issue by catching the `ValueError` raised by the `geopy.Point()` initializer and setting the waypoints location to `None`.
|
Great! Just one more change before merging: please use |
1 similar comment
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing waypoints from the HTML table it is not guaranteed that the location is in proper format, e.g. hidden stages have '???' in the location field (see e.g. GC3WTTZ). This caused an unhandled exception in
Waypoint.from_html().Fixing this issue by catching the
ValueErrorraised by thegeopy.Point()initializer and setting the waypoints location toNone.