Avoiding unnecessary Optional in JiraClient

tomasbjerre · Feb 19, 2016 · feeb61c · feeb61c
1 parent 32a6817
commit feeb61c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/se/bjurr/gitchangelog/internal/integrations/jira/DefaultJiraClient.java b/src/main/java/se/bjurr/gitchangelog/internal/integrations/jira/DefaultJiraClient.java
@@ -26,7 +26,7 @@ public Optional<JiraIssue> getIssue(String issue) {
   String endpoint = getEndpoint(issue);
   Optional<String> json = client.get(endpoint);
   if (json.isPresent()) {
-   JiraIssue jiraIssue = toJiraIssue(issue, json);
+   JiraIssue jiraIssue = toJiraIssue(issue, json.get());
    return of(jiraIssue);
   }
   return absent();

diff --git a/src/main/java/se/bjurr/gitchangelog/internal/integrations/jira/JiraClient.java b/src/main/java/se/bjurr/gitchangelog/internal/integrations/jira/JiraClient.java
@@ -21,8 +21,8 @@ protected String getEndpoint(String issue) {
   return endpoint;
  }
 
- protected JiraIssue toJiraIssue(String issue, Optional<String> json) {
-  String title = read(json.get(), "$.fields.summary");
+ protected JiraIssue toJiraIssue(String issue, String json) {
+  String title = read(json, "$.fields.summary");
   String link = api + "/browse/";
   JiraIssue jiraIssue = new JiraIssue(title, link, issue);
   return jiraIssue;