Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling getNextSemanticVersion() influences getHighestSemanticVersion() #170

Closed
sschuberth opened this issue Sep 20, 2023 · 4 comments
Closed

Comments

@sschuberth
Copy link

When calling getNextSemanticVersion() before getHighestSemanticVersion() (on the same GitChangelogApi instance), that influences the result of getHighestSemanticVersion().

In my test case, calling getHighestSemanticVersion() alone would result in "1.0.1", but if getNextSemanticVersion() is called before (which yields "1.1.0"), then getHighestSemanticVersion() suddenly returns "0.0.0".

Is this intended?

@tomasbjerre
Copy link
Owner

Sounds really strange, will have a look later.

@sschuberth
Copy link
Author

I believe this happens because of

which alters the state of the current GitChangelogApi.

@tomasbjerre
Copy link
Owner

I had a look, don't have time to work on it now but yes you are right. I'm putting it on my TODO.

@tomasbjerre
Copy link
Owner

Releasing a fix for this in 1.173.1. Open issue again if not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants