locationChunks in CppCheck are reported as individual violations

[uhafner]

I'm using your CppCheck parser in Jenkins Warnings plugin to read cppcheck files. In your parser you are converting each "location" of the original error structure to a violation. Actually each error should be converted to one violation only. Your violations should also provide a concept of multiple locations per violation (see SonarQube or Warning Plugin for an example).

See original Jenkins bug report.

[uhafner]

See discussion in https://issues.jenkins-ci.org/browse/JENKINS-55733.

[uhafner]

The discussion in the Jenkins issue seems to indicate, that each toplevel warning in the issue is the thing that should be counted.

[uhafner]

Do you think this is feasible? This will require changes in the API.

[tomasbjerre]

This library finds the id of each error and uses that as "rule" which is available on each Violation. Which means you can transform the list from the lib to a map of with one list per error. Does this help?

    final List<Violation> violationsList =
        violationsApi() //
            .withPattern(".*/cppcheck/example1\\.xml$") //
            .inFolder(rootFolder) //
            .findAll(CPPCHECK) //
            .violations();

    final Map<String, List<Violation>> violationsPerRule =
        violationsList
            .stream() //
            .collect(Collectors.groupingBy(Violation::getRule));
    assertThat(violationsPerRule) //
        .hasSize(2);
    assertThat(violationsPerRule.get("redundantAssignment")) //
        .hasSize(2);

[uhafner]

I think that will work. Thanks for the help!

[uhafner]

After thinking (or coding) it a little bit further I think that it does not work this way. The problem is that we can have multiple error tags using the same id (actually a bad name, id means rule id, it is not unique in the error tag).

[tomasbjerre]

Perhaps a group attribute can solve this?

    final List<Violation> violationsList =
        violationsApi() //
            .withPattern(".*/cppcheck/example1\\.xml$") //
            .inFolder(rootFolder) //
            .findAll(CPPCHECK) //
            .violations();

    final Map<String, List<Violation>> violationsPerGroupMap =
        violationsList
            .stream() //
            .collect(Collectors.groupingBy(Violation::getGroup));
    assertThat(violationsPerGroupMap) //
        .as("There are 2 error tags and there should be 2 groups identified.") //
        .hasSize(2);

So that in this example violationsPerGroupMap is a map with a key for each error tag and a value with a list of all location tags within that error tag.

[uhafner]

Ok, that should work now 👍

[uhafner]

Verified in jenkinsci/analysis-model@5e28d1b.