Parameterize the max line length for the report table. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an extra iteration across all violations in all cases. It’s possible to only do so when the max line length is specified, but doing so increases the number of branches and makes the code a bit harder to read. This also creates the FlipTable twice, once to measure the line lengths and then again after we’ve set our target line breaks. It’s also possible to make some assumptions about the whitespace and number of characters that FlipTable will add and avoid the second table creation. However, assuming that the construction of the table is not super performance critical, it seems more robust to just measure the output. A nice TODO might be to add coherent line breaking so we don’t break in the middle of words, but this isn’t technically a regression from the current 100 character message limit.
|
The Rule and Message columns seems to be the most common source to these problems... Maby the better (simpler) solution is to supply a fixed limit to all 4 columns? And just apply the |
|
Released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to optionally provide better formatting when printing to output that has strict line limits. In my case I'm particularly interested in the output in travis-ci's log. I've attached a screenshot that shows the current behavior when Travis' log line length is exceeded.
This could be more intelligent, but for now this just restricts the length of the message column. I've retained the existing behavior of allowing up to 100 characters in the message column if no line limit is specified.