Testing improvements and new replace_on_push parameter #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DbtDepsOperator could have unintended side-effects if it were to modify files outside of the packages directory. For this reason, we added a new test, and extended existing tests to ensure no files are changed in a dbt project outside of the dbt packages directory. This should provide more guarantees about the behavior of the operator, specially when looking to push back files to S3.
Setting replace_on_push to False will skip any S3 uploads when a key already exists. This is useful to guarantee no unexpected files are changed. I'm still not super convinced about the solution as ideally we would like partial replacing; only replacing changed files would be ideal. This is hard to do with compressed projects, as it would require downloading and uncompressing the project first. This has been left for future work.
tomasfarias
force-pushed
the
overwrite-toggle
branch
from
1d2454f
to
dd216ed
Compare
|
Closes #30 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DbtDepsOperator could have unintended side-effects if it were to
modify files outside of the packages directory. For this reason, we
added a new test, and extended existing tests to ensure no files are
changed in a dbt project outside of the dbt packages directory.
This should provide more guarantees about the behavior of the
operator, especially when looking to push back files to S3.
Moreover, this PR introduces a new parameter:
replace_on_push.Setting it to False will skip any S3 uploads when a key
already exists. This is useful to guarantee no unexpected files are
changed.
I'm still not super convinced about the solution as ideally
we would like partial replacing; only replacing changed files would be
ideal. This is hard to do with compressed projects, as it would
require downloading and uncompressing the project first. This has
been left for future work.