Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments by Luis #9

Closed
hojdars opened this issue Sep 27, 2018 · 1 comment
Closed

Comments by Luis #9

hojdars opened this issue Sep 27, 2018 · 1 comment
Assignees

Comments

@hojdars
Copy link
Collaborator

hojdars commented Sep 27, 2018

(following is written by Luis)

2.2.1 - Importing the model, můžeme tam zmínit ještě drag & drop jak má slicer

2.2.2 - triangle painter, vyměnil bych "triangle that faces toward him" za visible triangle
přijde mi to přesnější, jelikož triangly co nejsou vidět ale koukají k nám nás nezajímaj

potom ještě ohledně Command stacku
máme tam psáno že každý command si bude ukládat původní state, aby mohl dělat undo
přijde mi lepší ta implementace jak nás napadla kdysi na schůzce, že command má jen data pro redo, a původní stav bude uložen někde v Command Manager klidně každých x commandů
a undo bude probíhat načtením snapshotu a redo třeba 2-3 commandů

@hojdars
Copy link
Collaborator Author

hojdars commented Sep 27, 2018

Fixed in 926a607

Instead of exchanging the command implementation, I added it as a second variant (which should tell them we were thinking about it more than just copypasting the design pattern). Hopefully this is clear enough, if anyone feels like it needs clearing up, do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants