Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final UI polishing #97

Closed
41 tasks done
tomasiser opened this issue Jan 2, 2019 · 2 comments
Closed
41 tasks done

Final UI polishing #97

tomasiser opened this issue Jan 2, 2019 · 2 comments
Assignees
Milestone

Comments

@tomasiser
Copy link
Owner

tomasiser commented Jan 2, 2019

  • Provide tooltips for tools:
    • Triangle Painter
    • Paint Bucket
    • Brush
    • Text Editor
    • Automatic Segmentation
    • Manual Segmentation
    • Display Options
    • Settings
    • Information
    • Export Assistant
  • Antialiasing (does not seem to be possible to change MSAA at run-time, and creating some kind of a configuration for this would take too much effort; as a workaround, users may use the settings of their GPU to enable MSAA for Pepr3D)
  • Fill in Information tool
  • Fix font in File menu
  • Fix (missing) separator in Automatic/Manual Segmentation
  • Change "Reset model translation" to "Reset model transformation"
  • Hide Debug tool in Release
  • Provide fatal error dialogs:
    • If a font is not found (use default ImGui font for the dialog)
    • If defaultcube.stl is not found
    • If shaders are not found
    • Missing hotkeys.json is not an error!
  • Save all Cinder logs to a file pepr3d.log, fatals to pepr3d.fatal.log
  • Use Cinder logging automatically from Dialog.cpp
  • In Release, disable console and set CI_MIN_LOG_LEVEL to 3 (LEVEL_WARNING)
  • If an exception is uncaught and Pepr3D exits without a dialog (incl. when an exception is thrown while trying to display a fatal error dialog), use Cinder log files to save fatal errors and display an info dialog next time Pepr3D is launched (i.e., if pepr3d.fatal.log file exists when Pepr3D is launched, backup the original pepr3d.log into pepr3d.fatal.#.log file and show dialog and remove the .fatal.log file)
  • Provide warning & error & fatal error dialogs for tools:
    • Triangle Painter
    • Paint Bucket
    • Brush
    • Text Editor
    • Automatic Segmentation
    • Manual Segmentation
    • Display Options
    • Settings
    • Information
    • Import
    • Load
    • Save
    • Geometry (probably throw exceptions and handle from tools)
    • Export Assistant
@hojdars
Copy link
Collaborator

hojdars commented Jan 4, 2019

In https://github.com/tomasiser/pepr3d/tree/hojdy/error-dialogs

Provide warning & error & fatal error dialogs for tools:

  • Triangle Painter - AFAIK no dangerous places
  • Paint Bucket - bucket painter can throw an error if CGAL fails inside. Added the dialog.
  • Automatic Segmentation - added 2 dialogs - SDF computation and segmentation
  • Manual Segmentation - added 2 dialogs - SDF computation and bucket spreading of colors
  • Geometry - Added throws on multiple places
  • Save - added two dialogs for when the ofstream is not open (checked with .is_open)

Import and Load should be fine as there are plenty of error dialogs.
Export looks to be handled via Assimp, so no Dialogs there?
Settings contains the width of the sidepane and ColorPallete management. Sidepane should not fail, and ColorPallette looks to already have dialogs inside.
Display Options contains camera management which looks without possible errors, and model translation/rotation which looks without errors.
Information ...

I think that this is done.

@tomasiser
Copy link
Owner Author

Depending on how @Arokip handles the new Export, we should probably at least try to handle exceptions so they do not crash the whole Pepr3D. Let's wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants