Fix template #1
Merged
Fix template #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change default App Service Plan size to Basic. The Application Insights Profiler won't work with plan sizes below that. * Make the Web App settings change dependent upon the presence of the extension. Otherwise the settings change would cause the Web App to restart which would fail the deployment at the extension installation step. More on this here: https://stackoverflow.com/questions/45106303/app-insights-status-monitor-extension-failing-to-deploy-with-arm-template * Set the Application Insights' location to the location of the resource group.
tomasr
reviewed
Aug 16, 2018
WebSite.json
Outdated
| @@ -92,7 +92,8 @@ | |||
| "name": "appsettings", | |||
| "type": "config", | |||
| "dependsOn": [ | |||
| "[resourceId('Microsoft.Web/Sites', parameters('webSiteName'))]" | |||
| "[resourceId('Microsoft.Web/Sites', parameters('webSiteName'))]", | |||
| "Microsoft.ApplicationInsights.AzureWebSites" | |||
There was a problem hiding this comment.
Are you sure this dependency is specified correctly? I'm somewhat surprised it works.....
There was a problem hiding this comment.
To be honest with you I was quite surprised myself as well, but I tried it multiple times and the deployment always succeeded this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomas,
I found this code while reading your blog post. Excellent work, thank you! It certainly saved me a great deal of time.
But I found that the template itself is not working, hence I am providing the below fixes. I suggest you to update the blog post as well - in case you find my fixes worthy of a merge, of course. :)
Thanks,
Péter
Changes: