Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve / add more unit tests #177

Closed
tomastrajan opened this issue Apr 29, 2018 · 1 comment
Closed

Improve / add more unit tests #177

tomastrajan opened this issue Apr 29, 2018 · 1 comment
Labels
good first issue 🥇 help wanted 👋

Comments

@tomastrajan
Copy link
Owner

tomastrajan commented Apr 29, 2018 •
edited

Currently repository contains only test stubs generated by Angular CLI (for the corresponding components and services).

These test stubs contains only necessary imports so that the basic expect(component).toBeTruthy(); style test passes.

We need to improve tests to serve as a example for the users of this repository.

  • suggest best test practices
  • standardized imports for test related stuff
  • add unit tests for the component / service functionality
  • use community driven test library? (optional)

Tests can be added in step by step fashion with one PR corresponding to the tests of one component / service to keep the required effort low but please feel free to add more ;)

ps: please use commit message in format like feat(examples): add tests, #<issue-number>, just replace examples with applicable application part.
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 9, 2018
@shootermv
feat(shared): add tests, tomastrajan#177
f2867cb
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 10, 2018
@shootermv
feat(shared): add tests, tomastrajan#177
5144a31 
feat(shared): add tests tomastrajan#177
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 10, 2018
@shootermv
feat(shared): add tests, tomastrajan#177
1896105 
tests use 'Host' element
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 11, 2018
@shootermv
feat(shared): add tests, tomastrajan#177
4bc2f98 
trying remove lint errors
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 12, 2018
@shootermv
feat(shared): add tests, tomastrajan#177
314fe06
tomastrajan added a commit that referenced this issue May 13, 2018
@tomastrajan
Merge pull request #193 from shootermv/adding-unit-test-shared
ee17f82 
 feat(shared): add tests, #177
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 14, 2018
@shootermv
feat(unit-test): add test for action tomastrajan#177
fbd30ab
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 16, 2018
@shootermv
feat(unit-test): add test for action tomastrajan#177
8f01931 
using debugElement instead of  nativeElement
shootermv added a commit to shootermv/angular-ngrx-material-starter that referenced this issue May 17, 2018
@shootermv
feat(unit-test): add test for action tomastrajan#177
24f8145 
using create Element method
tomastrajan added a commit that referenced this issue May 19, 2018
@tomastrajan
Merge pull request #217 from shootermv/adding-test-for-action
ed74145 
feat(unit-test): add test for action of big input action component #177
@tomastrajan
Copy link
Owner Author

Closing this issue because it is too generic, will open additional issues (one per component / feature) to better track progress and to introduce ability to close issues with the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🥇 help wanted 👋
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomastrajan