Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animations in Safari seam to flicker #39

Closed
nblopes opened this issue Jan 16, 2018 · 2 comments
Closed

Animations in Safari seam to flicker #39

nblopes opened this issue Jan 16, 2018 · 2 comments

Comments

@nblopes
Copy link

nblopes commented Jan 16, 2018 •
edited

Been testing this in multiple browsers including Safari, Edge and IE11.

Safari:
The animations in Safari seam to flicker.

Edge: The animations in Edge seam to flicker.

IE11:
As it is does not run. IE11 does not support "includes" method in Strings. As a result its crashes. Use "indexOf" instead.
@tomastrajan
Copy link
Owner

Thank you very much for your effort will definitelly look into it. For IE11 the solution will be to import core-js polyfill to support includes.

@tomastrajan
Copy link
Owner

Still the animation fickleness is worth looking into.

tomastrajan added a commit that referenced this issue Jan 21, 2018
@tomastrajan
fix(styles): sticky footer animation flicker (IE11), fixes #39
9209ca2
tomastrajan added a commit that referenced this issue Jan 29, 2018
@tomastrajan
fix(core): correctly expand content section on route animation, fixes #…
2442f72 
…39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomastrajan @nblopes