Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little cleanup #21

Merged
merged 11 commits into from
Jul 13, 2015
Merged

Little cleanup #21

merged 11 commits into from
Jul 13, 2015

Conversation

tomato42
Copy link
Member

  • add reporting of cipher name to tls.py
  • actually support requesting of client cert in tls.py
  • make optional parameters to ServerHello really optional (1st step to depreciate them)
  • trivial fixups in Makefile
  • rename sendMessage and recvMessage since they don't handle messages, just record payloads
  • implement an easier-to-work-with abstraction on top of record layer - MessageSocket that does automatic defragmentation and allows for bundling messages together
  • extra test coverage for recordlayer (AEAD/AES128GCM ciphers)
  • extra test coverage for TLSExtension
  • put all handshake hash updates into a single place

@tomato42
ciphersuite name in tls.py
c33e0ac
@tomato42
actually support reqCert option in tls.py server
f716c2f 
the option is documented, is parsed from command line parameters
but it's not used, fix this error
@tomato42
make ServerHello not require providing optional parameters
f41f5c2
@tomato42
remove whitespace in Makefile
3408d60
@tomato42
rename sendMessage to sendRecord
2e5413d 
Because the RecordLayer method sendMessage actually sends
a record as-is without any fragmentation or length checks
(with the exception of the implicit length limit enforced by
two-byte length field), a better name for it is "sendRecord"

rename allowed since the API was not part of a stable release yet
@tomato42
rename recvMessage to recvRecord
7b06830 
Because the RecordLayer method recvMessage actually reads
a record and returns it to caller as-is without any defragmentation
or message splitting, a better name for it is "recvRecord"

rename allowed since the API was not part of a stable release yet
@tomato42
implement MessageSocket
0ac3e01 
add a wrapper around RecordLayer that makes it easier to handle
sending and receiving messages through it, especially aimed at
handling handshake messages
@tomato42
recordlayer AEAD test coverage
f0f5ee9
@tomato42
test coverage for TLSExtension
8c7f2b9
@tomato42
add class for handling handshake protocol hashes
229ea4f
@tomato42
use HandshakeHashes in TLSConnection
e71a7a9
@tomato42 tomato42 mentioned this pull request Jun 27, 2015
Closed
@landscape-bot
Copy link

Code Health
Repository health increased by 2% when pulling e71a7a9 on handshake-hashes-2 into bb6142c on master.

@tomato42 tomato42 added this to the v0.5.0 milestone Jun 27, 2015
@tomato42 tomato42 added the review request PR finished, ready for review label Jun 27, 2015
tomato42 added a commit that referenced this pull request Jul 13, 2015
@tomato42
Merge pull request #21 from tomato42/handshake-hashes-2
85eb7ba 
Little cleanup
@tomato42 tomato42 merged commit 85eb7ba into master Jul 13, 2015
@tomato42 tomato42 deleted the handshake-hashes-2 branch July 13, 2015 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review request PR finished, ready for review
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tomato42 @landscape-bot @joshbressers