Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicker RSA operations #415

Merged
merged 3 commits into from Jun 23, 2020
Merged

Quicker RSA operations #415

merged 3 commits into from Jun 23, 2020

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Jun 19, 2020

profile and speed up RSA operations, add support for gmpy2 for operations

also add tool for benchmarking

fixes #375


This change is Reviewable

@tomato42 tomato42 added the enhancement new feature to be implemented label Jun 19, 2020
@tomato42 tomato42 added this to the v0.8.0 milestone Jun 19, 2020
@tomato42 tomato42 self-assigned this Jun 19, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request introduces 3 alerts and fixes 7 when merging 79f6e00 into c6c9112 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

fixed alerts:

  • 4 for 'import *' may pollute namespace
  • 3 for Unused import

ensure that gmpy is used for all calculations in RSA, it speeds up
private key operations by about 5%
use gmpy2 if possible as it's faster than gmpy (and still developed)
Copy link
Collaborator

@ep69 ep69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tomato42 tomato42 merged commit 4521c5c into master Jun 23, 2020
@tomato42 tomato42 deleted the rsa-gmpy branch June 23, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature to be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for gmpy2
2 participants