Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependency on unittest for development #81

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Conversation

tomato42
Copy link
Member

No description provided.

@tomato42
Copy link
Member Author

@FiachAntaw: could you take a look? Should fix the issue with CONTRIBUTING.md you mentioned in #80

@tomato42 tomato42 added the review request PR finished, ready for review label Dec 14, 2015
@FiachAntaw
Copy link

I think the 'mock' module is distributed as a separate module for python 2 and isn't included in unittest2. It's needed by unit_tests/test_tlslite_recordlayer.py.

I'm testing the dependency list by doing the following to generate a fresh virtualenv:

cd tlslite-ng
# Make python2 virtualenv (needs virtualenv/virtualenvwrapper)
mkvirtualenv tlslite-test -p `which python2`
# Add local python3 binaries/libraries to the virtualenv
mkvirtualenv tlslite-test -p `which python3`
# Install dependencies
pip install unittest2 ecdsa pylint diff_cover coverage hypothesis tackpy m2crypto pycrypto gmpy
pip3 install ecdsa pylint diff_cover coverage hypothesis tackpy m2crypto pycrypto gmpy
# Run tests
make test-dev

Which at present fails with an ImportError on mock in the aforementioned file. Running pip install mock fixes the problem and all tests then complete without errors.

@tomato42
Copy link
Member Author

@FiachAntaw how about now? I've added explicit dependency on mock

@FiachAntaw
Copy link

Looks good to me.

tomato42 added a commit that referenced this pull request Dec 18, 2015
add dependency on unittest for development
@tomato42 tomato42 merged commit 0362b79 into master Dec 18, 2015
@tomato42 tomato42 deleted the contributing-unittest branch December 21, 2015 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review request PR finished, ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants