Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard score items expiration date timezone is wrong #258

Closed
potomak opened this issue Feb 6, 2017 · 0 comments
Closed

Leaderboard score items expiration date timezone is wrong #258

potomak opened this issue Feb 6, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@potomak
Copy link
Member

potomak commented Feb 6, 2017

Leaderboard score items don't expire according to users' timezones.

Example daily score item:

{ _id: ObjectId("5897e27a814334000672964f"), uid: ObjectId("4e2d3ec0ad7f170001000001"), s: NumberLong("1"), eat: ISODate("2017-02-06T23:59:59.999Z") }

This is a my today's score item. The expiration date is set at tomorrow's end of day even if in my timezone, America/New York, is still 02/05.

The issue is that IncrementScore#to_user_timezone chances a UTC time's timezone instead of computing the correct local time according to user's timezone.

@potomak potomak added the bug label Feb 6, 2017
@potomak potomak added this to the 0.14 milestone Feb 6, 2017
@bugant bugant self-assigned this Feb 7, 2017
bugant pushed a commit that referenced this issue Feb 7, 2017
bugant pushed a commit that referenced this issue Feb 7, 2017
bugant pushed a commit that referenced this issue Feb 7, 2017
@potomak potomak modified the milestones: 0.14.0, 0.14.1, 0.14.2 Mar 12, 2017
potomak pushed a commit that referenced this issue Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants