Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in ability to disable it #14

Closed

Conversation

tomatohater
Copy link
Owner

Opening new PR to replace #13 so that this is merged into a feature branch instead of master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.56%) to 99.44% when pulling 81715b2 on brechmos:master into 63a43de on tomatohater:feature/disable-filter.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.56%) to 99.44% when pulling 81715b2 on brechmos:master into 63a43de on tomatohater:feature/disable-filter.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.56%) to 99.44% when pulling 2c6fcee on brechmos:master into 63a43de on tomatohater:feature/disable-filter.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.56%) to 99.44% when pulling 2c6fcee on brechmos:master into 63a43de on tomatohater:feature/disable-filter.

@tomatohater
Copy link
Owner Author

One more comment... If not enabled, I'd just short circuit the filter and return "value" quickly:

def obfuscate(value, juice=None):
    if not settings.UNFRIENDLY_ENABLE:
        return value
    ....

This avoids the unnecessary execution of the rest of the method.

@tomatohater
Copy link
Owner Author

Closing in favor of #15.

@tomatohater tomatohater closed this Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants