Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of ELK & Update Compose #1614

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Getting rid of ELK & Update Compose #1614

merged 4 commits into from
Sep 21, 2020

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Sep 20, 2020

This PR starts the process of removing ELK from the current builds.

What has already been done?

  • The ELK directory has been removed
  • Removed docker-compose.elk.yml.dist
  • Removed docker-compose.filebeat.yml.dist
  • Updated Docker Compose files

What needs to be done?

  • The elk build on Docker Hub will be removed by @tomav

Rationale

For ELK, it's clear. Filebeat was removed with release 7, so removed this compose file too.

Docker Compose is currently on stable version 1.26.2 which translates to compose file version 3.8. I updated to 3.7 and formatted the YAML files properly.

@georglauterbach georglauterbach self-assigned this Sep 20, 2020
@georglauterbach georglauterbach linked an issue Sep 20, 2020 that may be closed by this pull request
@georglauterbach georglauterbach changed the title Getting rid of ELK WIP: Getting rid of ELK Sep 20, 2020
@georglauterbach georglauterbach changed the title WIP: Getting rid of ELK WIP: Getting rid of ELK & Update Compose Sep 21, 2020
@tomav
Copy link
Contributor

tomav commented Sep 21, 2020

Hi @aendeavor I can remove it from Docker Hub when new version will be merged/released.

@georglauterbach
Copy link
Member Author

Alright @tomav 👍🏼

FYI: This PR is ready for merging. I'll merge it in a few minutes, so you can proceed with removing the build from Docker Hub.

@georglauterbach georglauterbach changed the title WIP: Getting rid of ELK & Update Compose Getting rid of ELK & Update Compose Sep 21, 2020
@georglauterbach georglauterbach merged commit 9b5d4d3 into docker-mailserver:master Sep 21, 2020
@georglauterbach georglauterbach deleted the obsolete_elk branch September 21, 2020 11:54
@tomav
Copy link
Contributor

tomav commented Sep 23, 2020

ELK build dropped on Docker Hub.

@georglauterbach
Copy link
Member Author

I posted this in #1207 too, in case you wonder. Is there any way the /elk build in `ci/dockercloud/ is still active?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of ELK
2 participants