-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for detecting running container mount #884
Conversation
Can you rebase to master? |
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail, can you verify them?
Will do |
Ok, I'm working on this. I have successfully corrected all the tests. I have 2 issues:
I'll push my change to this branch later today. |
@callmemagnus the master merged a commit 59ce9d0 that fixes this issue. Could you rebase again on master to see if it solves the errors? |
Thanks for prompt answer @johansmitsnl, but I already had that commit. The command is failing in the test runner but not manually. I wonder if it is not a strange case of value escaping between my shell, the test suite, docker and the shell in the container. |
I don't get it. Travis returns errors on portions of code I haven't done anything on. On my laptop, with the current code I have 2 failures, both related to the doveadm working in cli but not in test suite:
I also added my fork to travis and the errors are the same than the ones I get on my machine: https://travis-ci.org/callmemagnus/docker-mailserver/jobs/366510534. |
This modification proposes to support the running configured mounted volume for configuration. This removes the need to pass a path from the command line when the container is running and configured in another way that yours.
I updated the branch but travis does not start this build. Can you trigger it ? I have the tests passing on my branch (see #950). |
Restarted jenkins |
run ./setup.sh email update lorem@impsum.org my password | ||
sleep 10 | ||
updatepass=$(cat ./config/postfix-accounts.cf | grep lorem@impsum.org | awk -F '|' '{print $2}') | ||
./setup.sh -c mail email add lorem@impsum.org test_test && initialpass=$(cat ./test/config/postfix-accounts.cf | grep lorem@impsum.org | awk -F '|' '{print $2}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that initialpass is not empty? I had timing problems with it before. Also -c mail
doesn't have an effect as the addmailuser
script is running on a temporary container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you say about -c mail
is not correct. My change is exactly changing that as it guesses the mounted volume of a container.
But you are right about the value of initialpass. I need to check if setup.sh
is returning when the task is done or not.
Anyway, the job on travis does not start on this PR :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarted the build
hmmm... Broken build again, this is getting frustrating. I think Travis is definitely showing its limit with this build. |
* Deliver root mail (Closes: #952) * don't update permissions on non-existent file (Closes: #956) * Update docker-configomat (Closes: #959) * Support for detecting running container mount (Closes: #884) * Report sender (Closes: #965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (Closes: #979, #980) * fix SASL domain (Closes: #892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (Closes: #989)
Release 6.1.0 * Deliver root mail (#952) * don't update permissions on non-existent file (#956) * Update docker-configomat (#959) * Support for detecting running container mount (#884) * Report sender (#965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (#979, #980) * fix SASL domain (#892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (#989)
This modification proposes to support the running configured mounted volume for configuration.
This removes the need to pass a path from the command line when the container is running and configured in another way that yours.