Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to improve the build #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Try to improve the build #1

wants to merge 2 commits into from

Conversation

tomayac
Copy link
Owner

@tomayac tomayac commented Nov 19, 2021

Fixes #2 (eventually… 🙄)

@tomayac tomayac mentioned this pull request Dec 30, 2021
@connorjclark
Copy link

connorjclark commented Apr 1, 2022

Uncertain what the issue is, but this is what I see when running this branch locally:

Uncaught (in promise) TypeError: svg.replaceAll is not a function

image

The return value is a number, likely the memory reference of the string generated in WASM. I'd look further but I see there's a lot of new code in main so it's not so simple to determine what isn't really working for you. If you rebaseline this branch and say more about the problem I'm happy to lend a hand.

FWIW, the changes in this PR seem correct to me. I'd expect it to work.


also a little confused why when building from master and running the demo, I don't see any WASM in the network panel. then I saw it was inlined in the JS as a data url 👀

@tomayac
Copy link
Owner Author

tomayac commented Apr 4, 2022

@connorjclark I have opened a new PR: #7. Leaving this one open for comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the build
2 participants