add support HVCControllers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomayac
reviewed
Sep 21, 2022
| if (joyCon instanceof JoyConLeft) { | ||
| const joystick = packet.analogStickLeft; | ||
| if (joyCon instanceof HVCController) { | ||
| // from left |
There was a problem hiding this comment.
Suggested change
| // from left | |
| // From left. |
tomayac
reviewed
Sep 21, 2022
| document | ||
| .querySelector('#joystick-left') | ||
| .classList.toggle('highlight', buttons.leftStick); | ||
| // from right |
There was a problem hiding this comment.
Suggested change
| // from right | |
| // From right. |
tomayac
reviewed
Sep 21, 2022
| */ | ||
| class HVCController extends JoyConRight { | ||
| /** | ||
| *Creates an instance of HVCController. |
There was a problem hiding this comment.
Suggested change
| *Creates an instance of HVCController. | |
| * Creates an instance of HVCController. |
tomayac
reviewed
Sep 21, 2022
| */ | ||
| class HVCController extends JoyConRight { | ||
| /** | ||
| *Creates an instance of HVCController. |
There was a problem hiding this comment.
Suggested change
| *Creates an instance of HVCController. | |
| * Creates an instance of HVCController. |
tomayac
reviewed
Sep 21, 2022
| @@ -48,12 +49,16 @@ const connectDevice = async (device) => { | |||
| if (device.productId === 0x2006) { | |||
| joyCon = new JoyConLeft(device); | |||
| } else if (device.productId === 0x2007) { | |||
| joyCon = new JoyConRight(device); | |||
| if (device.productName.startsWith("HVC Controller ")) { | |||
There was a problem hiding this comment.
Suggested change
| if (device.productName.startsWith("HVC Controller ")) { | |
| if (device.productName.startsWith('HVC Controller')) { |
tomayac
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for great code!
I added a support for HVCController.
https://twitter.com/taisukef/status/1572349705828569092