add support for fields that satisfy encoding.TextUnmarshaler #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (s *validTextUnmarshaler) UnmarshalText(text []byte) error { | ||
| s.DummyFloat = 1.0 |
There was a problem hiding this comment.
@nsaje here you only test if this method is called. Would you mind changing what this method does (and the corresponding tests you wrote), so we'll also test that the correct value get's passed to UnmarshalText?
|
@nsaje thank you so much for this PR! I'll definitely merge this. Before I do so .. I added one small comment above. Let me know if it makes sense to you. |
|
Is this what you had in mind? 😄 |
|
@nsaje Perfect! Thanks again 🤘 |
tomazk
added a commit
that referenced
this pull request
Mar 1, 2016
add support for fields that satisfy encoding.TextUnmarshaler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for fields that satisfy TextUnmarshaler interface. This allows defining custom data structures, example here https://github.com/BurntSushi/toml#using-the-encodingtextunmarshaler-interface