Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path $on click, stops working post pan #313

Closed
xamelion opened this issue Mar 6, 2014 · 9 comments
Closed

Path $on click, stops working post pan #313

xamelion opened this issue Mar 6, 2014 · 9 comments
Labels
Milestone

Comments

@xamelion
Copy link

xamelion commented Mar 6, 2014

when you move the map click stops working on paths

@SeyZ
Copy link

SeyZ commented Apr 9, 2014

💯 Same behavior.

@tombatossals Do you know if it's a angular-leaflet-directive issue?

@eczajk1
Copy link
Contributor

eczajk1 commented Feb 10, 2015

I have experienced the same problem. 😞

@tombatossals
Copy link
Owner

Could anyone post a jsfiddle with this behaviour?

@eczajk1
Copy link
Contributor

eczajk1 commented Feb 10, 2015

This fiddle should illustrate it. In summary, click events work fine on paths until the user pans the map. At that point, click events appear to no longer fire.

http://jsfiddle.net/eczajk1/9pb1Lons/

@nmccready nmccready changed the title $on click Path $on click, stops working post pan Jun 29, 2015
@nmccready nmccready added the bug label Jun 29, 2015
@nmccready nmccready added this to the 0.8.6 milestone Jun 29, 2015
This was referenced Jun 29, 2015
@tombatossals
Copy link
Owner

@nmccready, I was just investigating this issue, it seems that in the default event propagation behaviour, where all the path events are propagated, when the map is panned the events stop propagating.

But if you specify which events must be propagated, it's working ok. I have created an example, based on @eczajk1 jsfiddle, to illustrate it, I'm sending a PR.

@nmccready
Copy link
Contributor

thanks I'll take a look

@nmccready nmccready modified the milestones: 0.8.9, 0.8.8 Sep 3, 2015
@eczajk1
Copy link
Contributor

eczajk1 commented Sep 3, 2015

I wasn't privy to events broadcast directive, but I suppose it solves my issue, fyi.

@nmccready
Copy link
Contributor

This issue was moved to angular-ui/ui-leaflet#7

@nmccready nmccready reopened this Oct 29, 2015
@tombatossals
Copy link
Owner

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.

alex-exceed pushed a commit to alex-exceed/angular-leaflet that referenced this issue Oct 4, 2017
alex-exceed pushed a commit to alex-exceed/angular-leaflet that referenced this issue Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants