Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins not showing when map is re-instantiated #591

Closed
martinchristov opened this issue Jan 5, 2015 · 6 comments
Closed

Pins not showing when map is re-instantiated #591

martinchristov opened this issue Jan 5, 2015 · 6 comments

Comments

@martinchristov
Copy link

Hey there,
I've got a map with some pins that get populated via xhr when the controller function is executed.
When the view is instantiated the first time everything's great.
However when the user goes to another view and then comes back, the pins are not showing, although the xhr loads the same data correctly. Any following attempt to populate the pins object doesn't give any results.

Any ideas?

@martinchristov
Copy link
Author

I removed the XHR and the pins are now static. Same result :/

@martinchristov
Copy link
Author

Detected the source of the issue and found a workaround.
The issue was happening when the pins are under the same group.
Now I am generating a random group name string when the controller is hit and this fixes it.

I would say that this is a bug in the directive so I'm not closing the issue here.

@tombatossals
Copy link
Owner

Yes, it seems a bug. Could you provide a jsfiddle to reproduce the behaviour?

@Getz85
Copy link
Contributor

Getz85 commented Jan 6, 2015

I've exactly the same issue using a map into a bootstrap modal.

Indeed, generating a random group name works fine, thanks @martinchristov .

I've made a fiddle with my particular issue with bootstrap modal: http://jsfiddle.net/ext618u8/9/

@davidovich
Copy link
Contributor

I have experienced this also in the markers example.

Some preliminary debugging points to watches not being fired. I'm not sure as to why through.

@tombatossals
Copy link
Owner

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants