Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where you couldn't make visible a group of markers (overlay) created as not visible by default. Added example on how to create groups of markers and how to make them visible / not visible on demand. #225

Merged
merged 1 commit into from
Dec 20, 2013

Conversation

yagoferrer
Copy link

No description provided.

…) created as not visible by default. Added example on how to create groups of markers and how to make them visible / not visible on demand.
tombatossals added a commit that referenced this pull request Dec 20, 2013
fix(build): Fixed bug where you couldn't make visible a group of markers (overlay) created as not visible by default. Added example on how to create groups of markers and how to make them visible / not visible on demand.
@tombatossals tombatossals merged commit b0b1ebc into tombatossals:master Dec 20, 2013
@tombatossals
Copy link
Owner

Fantastic example @yagoferrer , like it a lot!

I'm going to add a new feature to it, make a group on the bootstrap buttons to be able to make them toggabble.

Thanks for the contribution!

tombatossals added a commit that referenced this pull request Dec 20, 2013
@yagoferrer
Copy link
Author

De res! For some reason the marker groups example did make it to your site:
http://tombatossals.github.io/angular-leaflet-directive/examples/marker-groups-example.html
Not sure why. Can you please take a look?

@tombatossals
Copy link
Owner

Solucionat :)

It was not published on the "gh-pages" branch, I have copied it to this branch and now it's working. It's a little redundant to have the "examples" directory duplicated on two branches, "master" and "gh-pages", but I think there's no solution for this.

@yagoferrer
Copy link
Author

Molt bé!
Have you tried this instead of copying the file over each time? http://stackoverflow.com/questions/10590156/git-update-the-root-directory-of-a-branch-from-the-subdirectory-of-another

@tombatossals
Copy link
Owner

Wow, very interesting thread, but I haven't used that git commands never, have to take a look at them closely.

It would be great the the "dist" and the "examples" directories of the "gh-pages" branch will be linked to the corresponding directories of the "master" branch.

I will try to make it work later, thanks.

@tombatossals
Copy link
Owner

Esier than I thought, folders from another branch can be merged into the actual branch doing a checkout and specifying the folder to be merged. For example:

$ # Go to gh-pages branch
$ git checkout gh-pages

# Get the lastest changes on master to the "examples" folder
$ git checkout master examples/

# Get the lastest changes on master to the "dist" folder
$ git checkout master dist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants