Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem running tests #334

Closed
cramatt opened this issue Nov 5, 2016 · 3 comments
Closed

Problem running tests #334

cramatt opened this issue Nov 5, 2016 · 3 comments

Comments

@cramatt
Copy link
Contributor

cramatt commented Nov 5, 2016

I've forked the repo with the intention of doing a PR but I can not get the tests to run. After running npm install, I get the following error when running `grunt test:unit

04 11 2016 23:37:26.190:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
04 11 2016 23:37:26.193:INFO [launcher]: Starting browser PhantomJS
04 11 2016 23:37:26.290:ERROR [launcher]: Cannot start PhantomJS

04 11 2016 23:37:26.294:INFO [launcher]: Trying to start PhantomJS again (1/2).
04 11 2016 23:37:26.384:ERROR [launcher]: Cannot start PhantomJS

04 11 2016 23:37:26.386:INFO [launcher]: Trying to start PhantomJS again (2/2).
04 11 2016 23:37:26.482:ERROR [launcher]: Cannot start PhantomJS

04 11 2016 23:37:26.484:ERROR [launcher]: PhantomJS failed 2 times (cannot start). Giving up.

node version: v4.6.0
npm version: 3.10.8
Mac os Sierra 10.12

@cramatt
Copy link
Contributor Author

cramatt commented Nov 5, 2016

So fixed the phantom issue thanks to this, karma-runner/karma-phantomjs-launcher#138 (comment), upgrading to recent phantom worked.

But now the tests are failing because of another error:

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  ReferenceError: Can't find variable: angular
  at /Users/mmiller/Sites/forks/angular-openlayers-directive/dist/angular-openlayers-directive.js:16

My question is are the tests still being maintained and do I need to get them passing for a new PR?

Thanks,
Matt

@cramatt
Copy link
Contributor Author

cramatt commented Nov 5, 2016

Gah - silly me I forgot to run bower install. Although a few things.

  1. still getting failed tests via phantom
  2. the contributing docs don't mention running bower install for testing (although its pretty standard but it does mention npm install)
  3. the output from running grunt is much shorter than what is documented in contributing... its only logging that it created a min file, but nothing else... ?

@juristr
Copy link
Collaborator

juristr commented Nov 5, 2016

😃

@juristr juristr closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants