Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix>: IE polyfill issue fix #358

Closed

Conversation

dulcedilip
Copy link

IE polyfill issue fix

startswith doesn't support in IE , so I have added polyfill support in olhelper.js.

2017-03-10 17_04_40-c__angular-openlayers-directive_examples_085-events-kml-example html - internet

IE polyfill issue fix
@juristr
Copy link
Collaborator

juristr commented Mar 10, 2017

@dulcedilip I just ran into this very same issue in my app 😄

But that said, I'd rather simply use indexOf at this point, basically this line from the polyfill

this.indexOf(searchString, 0) === 0;

..instead of including the polyfill code directly in the helpers file here. Could you maybe fix this in your branch? Also, please make sure to exclude the dist folder from the commit. That folder gets generated automatically during our build process and is actually not included in the master branch.

thanks a lot

@juristr juristr closed this in c32119f Mar 10, 2017
@juristr
Copy link
Collaborator

juristr commented Mar 10, 2017

@dulcedilip Had to fix this quickly as it caused us issues in production. Thanks a lot for your PR 👍

@dulcedilip
Copy link
Author

dulcedilip commented Mar 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants