Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WP editor as new form element #136

Merged
merged 2 commits into from Jun 20, 2016
Merged

Added WP editor as new form element #136

merged 2 commits into from Jun 20, 2016

Conversation

grubersjoe
Copy link
Contributor

@grubersjoe grubersjoe commented Jun 12, 2016

Feature #126

What do you think? As wp_editor() unfortunately echos the HTML directly, I used an output buffer.

Also I used array short syntax (supported since PHP v5.4). I think it's pretty safe to use nowadays, but if you'd like to support PHP 5.3 and below, I can also use the old syntax. I simply like it more personally.

@cyberscribe
Copy link
Collaborator

Hi Jonathan,

Thanks for doing this. Unfortunately the recommendation from the WordPress team is to maintain 5.3- compatibility as up to 15% of installations still run this version or below.

Best,
Robert

Sent from my iPhone

On 12 Jun 2016, at 19:51, Jonathan Gruber notifications@github.com wrote:

Feature #126

What do you think?

Also I used array short syntax (supported since PHP v5.4). I think it's pretty safe to use nowadays, but if you'd like to support PHP 5.3 and below, I can also use the old syntax. I simply like it more personally.

You can view, comment on, or merge this pull request online at:

#136

Commit Summary

Added WP editor as new form element
File Changes

M core/helpers/mvc_form_helper.php (39)
Patch Links:

https://github.com/tombenner/wp-mvc/pull/136.patch
https://github.com/tombenner/wp-mvc/pull/136.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@grubersjoe
Copy link
Contributor Author

No problem, I switched to the traditional syntax :).

Best,
Jonathan

@cyberscribe cyberscribe merged commit 57a81cf into tombenner:master Jun 20, 2016
@cyberscribe
Copy link
Collaborator

Thanks!

@grubersjoe grubersjoe deleted the iss126 branch September 13, 2016 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants