Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bcw 3928/webview size incorrect on orientation change while loading #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TombolaMatt
Copy link

Platforms affected

Android
iOS

What does this PR do?

(Android) Added safeguards against android.view.WindowManager$BadTokenException

  • Added a check to avoid opening the dialog if the activity is finishing
  • Wrapped the dialog.show() call in an try/catch to avoid crash if the other check doesn't work

(iOS) Fixed error with the webview displaying incorrectly if changing orientation while the page was still loading

  • Set the webview to match the screen bounds on viewWillAppear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant