Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is unexpectedly case sensitive #34

Closed
mlncn opened this issue Feb 12, 2018 · 6 comments
Closed

Search is unexpectedly case sensitive #34

mlncn opened this issue Feb 12, 2018 · 6 comments

Comments

@mlncn
Copy link

mlncn commented Feb 12, 2018

I thought search was broken but it's just case sensitive, when in my opinion (and in my experience with Tomboy) it shouldn't be, at least not by default.

(Still testing version 0.12 and my frame of reference is still the Tomboy available in Debian repositories.)

@davidbannon
Copy link
Member

Hmm, again this is a performance issue. Can be 'fixed' if desired but at the cost of speed. Might have to be an option ?

@mlncn
Copy link
Author

mlncn commented Feb 12, 2018

I have to push back on both these search issues. Search is the definition of when one uses an index. Search as case insensitive by default is definitely a user expectation across every web site, application, etc. in common use less grep.

@aguador
Copy link
Contributor

aguador commented Feb 13, 2018

Indeed I noted this as a problem as all text-based applications I have used are case insensitive by default, with most offering the option of overriding that for individual searches. The original Tomboy is not case sensitive for search, nor do I see an option in the application of plugins at the moment to make it case sensitive.

@davidbannon
Copy link
Member

You know nothing John Snow !
I know that the search function stops at the first xml tag in the note's text content ! Thats far more serious that the case issue or the wildcard issue combined. Sorry !
I believe its a bug in the xml parser I'm using but I am currently coding around it. And what I'm finding so far is slow. Sigh ....
Davo

@davidbannon
Copy link
Member

Have checked in code that allows user to choose, from Settings form to do a case sensitive search or not.
This check-in also fixes a significant problem in the search tools but at the expense of performance. Further research is indicated.

@davidbannon
Copy link
Member

Just checked in code that speeds up that search by factor of 100, now searches my test note directory of a 100 notes in about 35mS on my 'medium' speed laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants