Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent OneOf anonymous type name collisions #89

Closed
Tomboyo opened this issue Aug 9, 2023 · 1 comment
Closed

Prevent OneOf anonymous type name collisions #89

Tomboyo opened this issue Aug 9, 2023 · 1 comment

Comments

@Tomboyo
Copy link
Owner

Tomboyo commented Aug 9, 2023

Given the following component schema, Lily will try to render multiple classes with the same name. Lily should, if possible, prevent such a name collision from happening.

FooStringEmailAlias:
  type: string
Foo:
  oneOf:
    - type: string
      format: email

Bar1:
  type: object
 Bar:
  oneOf:
    - type: object

In the Foo case, our naming strategy for anonymous alias types collides with a root-level component. In the Bar case, our naming strategy for anonymous objects collides with the root level component.

@Tomboyo Tomboyo added this to the Compositional Types milestone Aug 9, 2023
@Tomboyo
Copy link
Owner Author

Tomboyo commented Oct 19, 2023

Closing as out-of-date with ADR 0002

@Tomboyo Tomboyo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant