Add repository information to JSON output. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test (GetNugetInformationAsync_Should_Resolve_Missing_NuSpec_File("FluentValidation,5.1.0.0")) works on my machine (Windows 10 x64, Visual Studio 2022). Any idea why it might fail? |
|
Given that other people's pull requests are failing on the same test (but on different architectures) I'm guessing that it's a flakey test. |
|
Hi @noname22, Thank you for PR. |
|
Thanks, good to hear that you're working on it. |
Closed
Merged
tomchavakis
approved these changes
Apr 11, 2022
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (our project) need to check the git repositories for licenses that override whatever nuget says. This adds the repository information to the json output format.