fix Timeout - Task Cancelled Exception #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeusink
suggested changes
Feb 23, 2023
src/Methods.cs
Outdated
| @@ -1055,6 +1064,11 @@ public async Task ExportLicenseTexts(List<LibraryInfo> infos) | |||
| // handled in !IsSuccessStatusCode, ignoring to continue export | |||
| break; | |||
| } | |||
| catch(TaskCanceledException ex) | |||
There was a problem hiding this comment.
HTTP Client sometimes throws an OperationCanceledException as well. Because TaskCanceledException derives from OperationCanceledException we can catch OperationCanceledException and slightly adjust our log message to handle both exceptions.
Suggested change
| catch(TaskCanceledException ex) | |
| catch(OperationCanceledException ex) |
There was a problem hiding this comment.
Thank you for the recommendation. I pushed a new commit.
src/Methods.cs
Outdated
| @@ -1055,6 +1064,11 @@ public async Task ExportLicenseTexts(List<LibraryInfo> infos) | |||
| // handled in !IsSuccessStatusCode, ignoring to continue export | |||
| break; | |||
| } | |||
| catch(TaskCanceledException ex) | |||
| { | |||
| WriteOutput($"Task Cancelled Exception during download of license url {info.LicenseUrl} exception {ex.Message}", logLevel: LogLevel.Verbose); | |||
There was a problem hiding this comment.
Suggested change
| WriteOutput($"Task Cancelled Exception during download of license url {info.LicenseUrl} exception {ex.Message}", logLevel: LogLevel.Verbose); | |
| WriteOutput($"{ex.GetType().Name} during download of license url {info.LicenseUrl} exception {ex.Message}", logLevel: LogLevel.Verbose); |
dbeusink
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with the following issue:
#182