-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapHolderRef only gets attached to direct child #94
Comments
Something like |
I hit this too. Would you consider documenting this decision? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great library! Just one hiccup I've noticed so far:
When including a child in
<GoogleMap>
that could include an object (such as aMarker
) the magicmapHolderRef
property doesn't get attached to the underlyingMarker
object.For example creating a structure something like:
Will result in none of the
<Markers />
having the necessary property set. The current workaround is to add a property inMyMarketHolder
that establishes the link:The relevant code in creators/GoogleMapHolder.js - perhaps that should be something like a recursive descent instead?
The text was updated successfully, but these errors were encountered: