adding support for multiple values for search filter #3541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most likely we're going to want to stay with the simplest possible implementation, but I'm likely to be reviewing the filter classes with 3.4, since 3.3 introduces a bunch of nice "include this in the browsable API" functionality that it'd be good to make some more extensive use of. |
|
On re-review, would rather see any new functionality for SearchFilter to be made as a third party package. |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple search params, instead of just one.
With current master, this will create a query only for the
lastparameter. You could add more params using space or ','. I think it's better to use the fact that we can specify more values for one param instead of using space or commas, especially when we would like to search using those characters.I've left backward compatibility for just one parameter given to split across spaces or commas, but I would remove this out in the future.
What do you think guys?
All the best,
Michal