Raise error when setting a removed rest_framework setting for #3644 #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amework into settings_errors
…amework into settings_errors
| @@ -135,6 +135,15 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| SETTINGS_DOC = "http://www.django-rest-framework.org/api-guide/settings/" | |||
There was a problem hiding this comment.
I don't think it's required to make it a setting.
lsanpablo
force-pushed
the
settings_errors
branch
from
ffe0288
to
dab6bf4
Compare
|
I agree with you, so I've updated the PR to throw a warning instead. |
tomchristie
added a commit
that referenced
this pull request
Dec 18, 2015
Raise error when setting a removed rest_framework setting for #3644
|
Thanks. That'll do as an improvement. |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the error message is detailed enough. Does anyone have a better solution?