make sure that we don't break import state checks

tomcz · Jul 5, 2024 · 2a92ed0 · 2a92ed0
1 parent e2f6239
commit 2a92ed0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/src/main/java/com/tomczarniecki/jpasskeep/Entry.java b/src/main/java/com/tomczarniecki/jpasskeep/Entry.java
@@ -99,6 +99,14 @@ public void setNotes(String notes) {
         this.notes = notes;
     }
 
+    public void updateFrom(Entry other) {
+        this.setDescription(other.getDescription());
+        this.setCategory(other.getCategory());
+        this.setUsername(other.getUsername());
+        this.setPassword(other.getPassword());
+        this.setNotes(other.getNotes());
+    }
+
     public int compareTo(Entry other) {
         return this.getDescription().compareToIgnoreCase(other.getDescription());
     }

diff --git a/src/main/java/com/tomczarniecki/jpasskeep/MainListModel.java b/src/main/java/com/tomczarniecki/jpasskeep/MainListModel.java
@@ -73,11 +73,8 @@ public void setEntry(Entry entry) {
                 entries.put(entry.getKey(), entry);
             } else if (state.equals(ImportState.Changed)) {
                 for (Entry current : entries.values()) {
-                    if (current.getDescription().equals(entry.getDescription())) {
-                        current.setCategory(entry.getCategory());
-                        current.setUsername(entry.getUsername());
-                        current.setPassword(entry.getPassword());
-                        current.setNotes(entry.getNotes());
+                    if (current.compareTo(entry) == 0) {
+                        current.updateFrom(entry);
                     }
                 }
             }
@@ -143,10 +140,10 @@ private boolean show(Entry entry) {
         };
     }
 
-    public ImportState stateForEntry(Entry otherEntry) {
-        for (Entry entry : entries.values()) {
-            if (entry.getDescription().equals(otherEntry.getDescription())) {
-                if (entry.equals(otherEntry)) {
+    public ImportState stateForEntry(Entry entry) {
+        for (Entry current : entries.values()) {
+            if (current.compareTo(entry) == 0) {
+                if (current.equals(entry)) {
                     return ImportState.Equal;
                 }
                 return ImportState.Changed;