Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: replace_refs_factory() missing 1 required positional argument: 'target' #46

Closed
tomduck opened this issue Jan 14, 2018 · 5 comments
Labels

Comments

@tomduck
Copy link
Owner

tomduck commented Jan 14, 2018

The above error with pandoc-fignos was reported at greenelab/deep-review:

The problem: There is an API incompatibility between pandoc-fignos 1.0.0 and pandoc-xnos 0.15 (the library for the pandoc-xnos/eqnos/tablenos filters).

The solution: Upgrade to the most recent version of pandoc-fignos.

I would like to prevent such errors from occurring in the future. One way forward is to move pandoc-xnos to MAJOR.MINOR.PATCH versioning and require a particular MAJOR.MINOR version for a given pandoc-fignos release. The MINOR number would be incremented for API changes.

Feedback is welcome.

@dhimmel
Copy link

dhimmel commented Jan 14, 2018

The MINOR number would be incremented for API changes

Do you mean MAJOR or MINOR. My understanding is that you're proposing that breaking API changes in the pandoc-xnos architecture would increment the MAJOR version?

In other words, the idea here is to make sure fignos and xnos are both using the same MAJOR, or the same MAJOR.MINOR?

@tomduck
Copy link
Owner Author

tomduck commented Jan 14, 2018

My mistake. It is the MAJOR version number that I should be changing in pandoc-xnos when there are API changes. Pandoc-fignos will require a particular MAJOR version number of the pandoc-xnos library. This will be written into the pandoc-fignos setup, so it should be completely transparent to users. Thanks for the feedback.

@dhimmel
Copy link

dhimmel commented Jan 14, 2018

It is the MAJOR version number that I should be changing in pandoc-xnos when there are API changes.

Got it! Makes sense to me.

@tomduck
Copy link
Owner Author

tomduck commented Jan 15, 2018

pandoc-xnos 1.0.1 is now released, and the requirement that pandoc-fignos use pandoc-xnos>=1.0.1,<2 is published in the nextrelease branch.

I don't think that publishing a new release is urgent, but users should let me know if they disagree. Otherwise the changes will go out when I have finished some other work in the queue. I also want to keep this Issue open in case others encounter the same problem.

@tomduck tomduck added the bug label Jan 15, 2018
dhimmel added a commit to dhimmel/manubot-rootstock that referenced this issue Feb 6, 2018
Should upstream fix issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
dhimmel added a commit to manubot/rootstock that referenced this issue Feb 6, 2018
Fix upstream issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
dhimmel added a commit to manubot/rootstock that referenced this issue Feb 6, 2018
This build is based on
310dd07.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/338192586
https://travis-ci.org/greenelab/manubot-rootstock/jobs/338192587

[ci skip]

The full commit message that triggered this build is copied below:

Update environment on 2018-02-06 (#108)

Fix upstream issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
dhimmel added a commit to manubot/rootstock that referenced this issue Feb 6, 2018
This build is based on
310dd07.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/338192586
https://travis-ci.org/greenelab/manubot-rootstock/jobs/338192587

[ci skip]

The full commit message that triggered this build is copied below:

Update environment on 2018-02-06 (#108)

Fix upstream issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
@tomduck
Copy link
Owner Author

tomduck commented Aug 9, 2018

I'm closing this in anticipation of a new release today.

@tomduck tomduck closed this as completed Aug 9, 2018
adebali pushed a commit to CompGenomeLab/lemur-manuscript-archive that referenced this issue Mar 4, 2020
Fix upstream issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants