Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Failed to restore message" #146

Closed
justanotheranonymoususer opened this issue Sep 30, 2023 · 21 comments
Closed

"Failed to restore message" #146

justanotheranonymoususer opened this issue Sep 30, 2023 · 21 comments
Labels

Comments

@justanotheranonymoususer

Looks like it's no longer able to restore deleted message

image

@tomer8007
Copy link
Owner

It seems WhatsApp made the XMPP acknowledgments mechanism more robust and added something called LID. Looking. I can get restored messages when they get deleted while the WhatsApp window is open, though.

@tomer8007
Copy link
Owner

tomer8007 commented Oct 1, 2023

OK, I committed a8ff5fc which seems to make the message restore feature work fine for me now. Please let me know if this changes stuff for you too.

BTW some changes that WhatsApp made are for integration with third party messaging apps.

@justanotheranonymoususer
Copy link
Author

Still doesn't work for me sadly. ver 2.1.0, does it contain the fix?

@tomer8007
Copy link
Owner

It should :-(
Javascript errors? Also I'm talking about the restore of new messages, of course.

@justanotheranonymoususer
Copy link
Author

Also I'm talking about the restore of new messages, of course.

yes sure

lots of errors:

image

@tomer8007
Copy link
Owner

Ah, I see. I hope to encounter this error in the upcoming days. If you feel like debugging in the meantime you can enable WAdebug = true and try to see for yourself if the revoke message is really the one that fails decryption.

@justanotheranonymoususer
Copy link
Author

It stops here on every msg I receive. Not sure what else I can debug, lmk.
image

@tomer8007
Copy link
Owner

tomer8007 commented Oct 4, 2023

Does the Cannot convert undefined or null to object exception happen for messages from all contacts/groups? Did you try other accounts/re-logging in? I ask because for me it works.

@justanotheranonymoususer
Copy link
Author

Does the Cannot convert undefined or null to object exception happen for messages from all contacts/groups?

Yes, seems like it

Did you try other accounts/re-logging in? I ask because for me it works.

I don't have other accounts, cleared all data of web.whatsapp.com and logged in from start but same errors still

@aviv926
Copy link

aviv926 commented Oct 18, 2023

Is there any new information about this?
For me it doesn't even show the message Failed to restore message

Also, thanks for this amazing project and the investment of time in its development

@tomer8007
Copy link
Owner

tomer8007 commented Oct 18, 2023

@aviv926 Sadly there is no new information because this feature works for me. I also tried with WA Web Plus enabled too. Thanks for the warm words though

Do you get the same error as @justanotheranonymoususer ?

@aviv926
Copy link

aviv926 commented Oct 18, 2023

@aviv926 Sadly there is no new information because this feature works for me. I also tried with WA Web Plus enabled too. Thanks for the warm words though

Do you get the same error as @justanotheranonymoususer ?

This might not be such a smart question on my part, but are you using the published version in the repository here? I'm assuming you're using git so I guess this question doesn't make much sense.

thank you for the answer

@justanotheranonymoususer
Copy link
Author

@tomer8007
Copy link
Owner

I'm using the version from the git repository.

@aviv926
Copy link

aviv926 commented Oct 18, 2023

I'm using the version from the git repository.

I seem to have figured out what the problem is
When the WhatsApp interface is in a language other than English, the message "Failed to restore messages" is not displayed as soon as you change the language to English, the message "Failed to restore messages" is displayed but is not yet restored

Could you please specify what your setup is?
What language interface?
And what is the version of your WhatsApp?
Also are you running the extension on chrome?

It is important for me to note that in previous versions it worked without a problem with a system interface that is not English
Thanks

@tomer8007
Copy link
Owner

I tested it on both English and non-english setups, and yes, I'm using chrome. However I just encountered the following error which I think is the same error you're getting:

image

@aviv926
Copy link

aviv926 commented Oct 19, 2023

I tested it on both English and non-english setups, and yes, I'm using chrome. However I just encountered the following error which I think is the same error you're getting:

image

Does this mean there is a problem with the extension? Or does it have nothing to do with it and the problem is on my side and not in the extension?
Sorry, I didn't quite understand

@tomer8007
Copy link
Owner

I'm sure there is a problem with the extension, I just need to reproduce it.

@tomer8007
Copy link
Owner

@aviv926 @justanotheranonymoususer Can you tell if the newer version fixes the restore of messages?

@justanotheranonymoususer
Copy link
Author

@tomer8007
Copy link
Owner

OK, if it looks like a real problem you can open another issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants